jitsi-meet
jitsi-meet copied to clipboard
feat(participants-pane) consolidate moeration options
They are now under a single "Moderator" button.
I'm not sure what to do about the config options to hide these buttons. Should we rename it to say "hideModeratorButton" ? Does anyone see the need for having individual hiding options if they are under the same menu? I'd say no...
Apologies for butting in.
Not sure how common a use case this is, but in our setup most of our users get moderator privileges and the "Allow attendees to:" actions sometimes cause confusion because others can still unmute themselves and enable video (because they are also moderator).
Given a choice, I would enable the "Mute all" and "Stop everyone's video" options but hide the other AV moderation actions to avoid confusion.
But not a big deal if it's all or nothing.
The web part LGTM. I'll leave the native to Calin
Apologies for butting in.
Not sure how common a use case this is, but in our setup most of our users get moderator privileges and the "Allow attendees to:" actions sometimes cause confusion because others can still unmute themselves and enable video (because they are also moderator).
Given a choice, I would enable the "Mute all" and "Stop everyone's video" options but hide the other AV moderation actions to avoid confusion.
But not a big deal if it's all or nothing.
Thanks for the feedback! Do you think changing the text would help? Something like "Allow non-moderators to: ..."
Changing to something like "Allow non-moderators to: ..." would certainly help! 👍
I'm not sure what to do about the config options to hide these buttons. Should we rename it to say "hideModeratorButton" ? Does anyone see the need for having individual hiding options if they are under the same menu? I'd say no...
I agree that hideMoreActionsButton
and hideMuteAllButton
can be deprecated in favour of a single more comprehensive option. I'd change the name though, if we plan to include the hideModeratorSettingsTab
functionality (hideModeratorOptions?). Otherwise, there is no reason for it to stay in the participantsPane config.
I'm not sure what to do about the config options to hide these buttons. Should we rename it to say "hideModeratorButton" ? Does anyone see the need for having individual hiding options if they are under the same menu? I'd say no...
I agree that
hideMoreActionsButton
andhideMuteAllButton
can be deprecated in favour of a single more comprehensive option. I'd change the name though, if we plan to include thehideModeratorSettingsTab
functionality (hideModeratorOptions?). Otherwise, there is no reason for it to stay in the participantsPane config.
I agree. Now, in terms of backwards compatibility, how would you translate the old options into the new one?
I agree. Now, in terms of backwards compatibility, how would you translate the old options into the new one?
Let's enforce the interfaceConfig.SETTINGS_SECTIONS in the cases where we get opposite values and see whether it's relevant to keep the hideMuteAllButton: false
working when there's no moderation button.
The web part LGTM. I'll leave the native to Calin
Native part LGTM.
Thanks! I'll add the backwards compat bits before merge.
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Please fix conflicts, if this is ready for review. Thanks!