jitsi-meet icon indicating copy to clipboard operation
jitsi-meet copied to clipboard

feat(participants-pane) consolidate moeration options

Open saghul opened this issue 2 years ago • 10 comments

They are now under a single "Moderator" button. Screenshot 2022-07-20 at 15 57 30 Screenshot 2022-07-20 at 15 54 29 Screenshot 2022-07-20 at 15 51 53

saghul avatar Jul 20 '22 14:07 saghul

I'm not sure what to do about the config options to hide these buttons. Should we rename it to say "hideModeratorButton" ? Does anyone see the need for having individual hiding options if they are under the same menu? I'd say no...

saghul avatar Jul 20 '22 14:07 saghul

Apologies for butting in.

Not sure how common a use case this is, but in our setup most of our users get moderator privileges and the "Allow attendees to:" actions sometimes cause confusion because others can still unmute themselves and enable video (because they are also moderator).

Given a choice, I would enable the "Mute all" and "Stop everyone's video" options but hide the other AV moderation actions to avoid confusion.

But not a big deal if it's all or nothing.

shawnchin avatar Jul 20 '22 20:07 shawnchin

The web part LGTM. I'll leave the native to Calin

robertpin avatar Jul 21 '22 08:07 robertpin

Apologies for butting in.

Not sure how common a use case this is, but in our setup most of our users get moderator privileges and the "Allow attendees to:" actions sometimes cause confusion because others can still unmute themselves and enable video (because they are also moderator).

Given a choice, I would enable the "Mute all" and "Stop everyone's video" options but hide the other AV moderation actions to avoid confusion.

But not a big deal if it's all or nothing.

Thanks for the feedback! Do you think changing the text would help? Something like "Allow non-moderators to: ..."

saghul avatar Jul 21 '22 08:07 saghul

Changing to something like "Allow non-moderators to: ..." would certainly help! 👍

shawnchin avatar Jul 21 '22 10:07 shawnchin

I'm not sure what to do about the config options to hide these buttons. Should we rename it to say "hideModeratorButton" ? Does anyone see the need for having individual hiding options if they are under the same menu? I'd say no...

I agree that hideMoreActionsButton and hideMuteAllButton can be deprecated in favour of a single more comprehensive option. I'd change the name though, if we plan to include the hideModeratorSettingsTab functionality (hideModeratorOptions?). Otherwise, there is no reason for it to stay in the participantsPane config.

mihhu avatar Jul 21 '22 11:07 mihhu

I'm not sure what to do about the config options to hide these buttons. Should we rename it to say "hideModeratorButton" ? Does anyone see the need for having individual hiding options if they are under the same menu? I'd say no...

I agree that hideMoreActionsButton and hideMuteAllButton can be deprecated in favour of a single more comprehensive option. I'd change the name though, if we plan to include the hideModeratorSettingsTab functionality (hideModeratorOptions?). Otherwise, there is no reason for it to stay in the participantsPane config.

I agree. Now, in terms of backwards compatibility, how would you translate the old options into the new one?

saghul avatar Jul 21 '22 12:07 saghul

I agree. Now, in terms of backwards compatibility, how would you translate the old options into the new one?

Let's enforce the interfaceConfig.SETTINGS_SECTIONS in the cases where we get opposite values and see whether it's relevant to keep the hideMuteAllButton: false working when there's no moderation button.

mihhu avatar Jul 21 '22 13:07 mihhu

The web part LGTM. I'll leave the native to Calin

Native part LGTM.

Calinteodor avatar Jul 22 '22 11:07 Calinteodor

Thanks! I'll add the backwards compat bits before merge.

saghul avatar Jul 22 '22 12:07 saghul

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 04 '23 01:09 github-actions[bot]

Please fix conflicts, if this is ready for review. Thanks!

Calinteodor avatar Sep 18 '23 11:09 Calinteodor