jitsi-meet icon indicating copy to clipboard operation
jitsi-meet copied to clipboard

fix(screenshot-capture): add try catch block for processing screenshot

Open gabiborlea opened this issue 2 years ago • 2 comments

Screen Shot 2022-07-18 at 4 55 40 PM couldn't reproduce the error but it seems that there is an uncaught error when calling that function

gabiborlea avatar Jul 19 '22 13:07 gabiborlea

I don't think this solves the "browser seems blocked" problem. Catching the exception and logging won't magically remove the pressure.

I think there should be a queue that runs at most X of these jobs concurrently to make sure that even if it takes 3 hours to upload a single image, it would not have tons of them running concurrently.

saghul avatar Jul 20 '22 06:07 saghul

I don't think this solves the "browser seems blocked" problem. Catching the exception and logging won't magically remove the pressure.

I think there should be a queue that runs at most X of these jobs concurrently to make sure that even if it takes 3 hours to upload a single image, it would not have tons of them running concurrently.

added some sort of a queue

gabiborlea avatar Jul 20 '22 09:07 gabiborlea

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 06 '23 01:09 github-actions[bot]

Is this still relevant Gabi?

saghul avatar Sep 06 '23 06:09 saghul

I think the endpoint has been change to not return 500 anymore so the change might not be needed here anymore

gabiborlea avatar Sep 06 '23 09:09 gabiborlea

Alright, let's close for now.

saghul avatar Sep 07 '23 10:09 saghul