jitsi-meet icon indicating copy to clipboard operation
jitsi-meet copied to clipboard

[IOS] Native PIP Not working

Open SindhujaKanukolanu opened this issue 2 years ago • 10 comments

I have updated JitsiSDK with latest PIP changes. PIP is not working at all. Are there any properties need to be set? This is the latest commit i consumed for PIP https://github.com/jitsi/jitsi-meet/commit/7f2fec756d8095000dd6976e2cc4f6906cf9d32e

SindhujaKanukolanu avatar Jul 12 '22 13:07 SindhujaKanukolanu

We have released SDK 6.0.0, please test that release.

saghul avatar Jul 12 '22 14:07 saghul

I have added below code by incorporating latest changes. Jitsi meet view delegate is not calling the methods. Please let me know if anything is missing

let sampleBufferVideoCallView = SampleBufferVideoCallView()
      sampleBufferVideoCallView.sampleBufferDisplayLayer.preventsCapture = false
      pipVideoCallViewController = AVPictureInPictureVideoCallViewController()
      pipVideoCallViewController?.preferredContentSize = CGSize(width: 500, height: 500)
      pipVideoCallViewController?.view.addSubview(sampleBufferVideoCallView)
      let pipContentSource = AVPictureInPictureController.ContentSource(activeVideoCallSourceView: jitsiMeetView,contentViewController: pipVideoCallViewController!)

      pipController = AVPictureInPictureController(contentSource: pipContentSource)
      pipController?.canStartPictureInPictureAutomaticallyFromInline = true
      pipController?.delegate = self
      DispatchQueue.main.async {
        self.pipController?.startPictureInPicture()
      }

SindhujaKanukolanu avatar Jul 13 '22 04:07 SindhujaKanukolanu

We tried using the native PiP API, but alas it looks like that approach won't work. @alexbumbu do you remember the details?

saghul avatar Jul 13 '22 08:07 saghul

@saghul that's where we're at too. Similar implementation to @SindhujaKanukolanu's and the delegate methods are not called.

alexbumbu avatar Jul 13 '22 13:07 alexbumbu

Yes we are also facing the same issue

SindhujaKanukolanu avatar Jul 13 '22 14:07 SindhujaKanukolanu

As far as we know it might not be possible to implement that easily. We do provide a PiP implementation which doesn't work outside of the host app.

saghul avatar Jul 13 '22 15:07 saghul

Okay thanks for the update. But is it in Pipe to support outside the app @saghul

SindhujaKanukolanu avatar Jul 13 '22 16:07 SindhujaKanukolanu

It is in our roadmap, yeah.

saghul avatar Jul 13 '22 16:07 saghul

Any timeline update you can give

SindhujaKanukolanu avatar Jul 13 '22 16:07 SindhujaKanukolanu

Not at the moment, sorry.

saghul avatar Jul 13 '22 16:07 saghul

Hello, is there any progress in this issue ?? in either SDK or The APP ??

MahmoudMamdoouh avatar Dec 04 '22 07:12 MahmoudMamdoouh

We are not aware of any PiP issues on our latest SDK, 7.0.0.

Can you reproduce the problem with the sample app?

saghul avatar Dec 04 '22 10:12 saghul

I meant the ios pip outside the app

MahmoudMamdoouh avatar Dec 04 '22 10:12 MahmoudMamdoouh

Ah no, sorry. We tried it but we need to implement it se lowest level, in the WebRTC plugin, so it went back to the TODO list.

saghul avatar Dec 04 '22 14:12 saghul

is there any expected time for it?

I really appreciate your hard work.

MahmoudMamdoouh avatar Dec 04 '22 15:12 MahmoudMamdoouh

I'll be honest: no there isn't.

Thanks for your kind words!

saghul avatar Dec 04 '22 18:12 saghul

@saghul Hi! Any updates? Or when do you plan to integrate this feature?

tmbiOS avatar Aug 05 '23 19:08 tmbiOS

No updates. We have no short term plans to tackle this, sorry.

saghul avatar Aug 05 '23 19:08 saghul

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 05 '23 01:10 github-actions[bot]