jitsi-meet
jitsi-meet copied to clipboard
[IOS] Native PIP Not working
I have updated JitsiSDK with latest PIP changes. PIP is not working at all. Are there any properties need to be set? This is the latest commit i consumed for PIP https://github.com/jitsi/jitsi-meet/commit/7f2fec756d8095000dd6976e2cc4f6906cf9d32e
We have released SDK 6.0.0, please test that release.
I have added below code by incorporating latest changes. Jitsi meet view delegate is not calling the methods. Please let me know if anything is missing
let sampleBufferVideoCallView = SampleBufferVideoCallView()
sampleBufferVideoCallView.sampleBufferDisplayLayer.preventsCapture = false
pipVideoCallViewController = AVPictureInPictureVideoCallViewController()
pipVideoCallViewController?.preferredContentSize = CGSize(width: 500, height: 500)
pipVideoCallViewController?.view.addSubview(sampleBufferVideoCallView)
let pipContentSource = AVPictureInPictureController.ContentSource(activeVideoCallSourceView: jitsiMeetView,contentViewController: pipVideoCallViewController!)
pipController = AVPictureInPictureController(contentSource: pipContentSource)
pipController?.canStartPictureInPictureAutomaticallyFromInline = true
pipController?.delegate = self
DispatchQueue.main.async {
self.pipController?.startPictureInPicture()
}
We tried using the native PiP API, but alas it looks like that approach won't work. @alexbumbu do you remember the details?
@saghul that's where we're at too. Similar implementation to @SindhujaKanukolanu's and the delegate methods are not called.
Yes we are also facing the same issue
As far as we know it might not be possible to implement that easily. We do provide a PiP implementation which doesn't work outside of the host app.
Okay thanks for the update. But is it in Pipe to support outside the app @saghul
It is in our roadmap, yeah.
Any timeline update you can give
Not at the moment, sorry.
Hello, is there any progress in this issue ?? in either SDK or The APP ??
We are not aware of any PiP issues on our latest SDK, 7.0.0.
Can you reproduce the problem with the sample app?
I meant the ios pip outside the app
Ah no, sorry. We tried it but we need to implement it se lowest level, in the WebRTC plugin, so it went back to the TODO list.
is there any expected time for it?
I really appreciate your hard work.
I'll be honest: no there isn't.
Thanks for your kind words!
@saghul Hi! Any updates? Or when do you plan to integrate this feature?
No updates. We have no short term plans to tackle this, sorry.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.