jitsi-meet-torture icon indicating copy to clipboard operation
jitsi-meet-torture copied to clipboard

Published 20 hours ago • verified publisher icon jitsi

support port which not default to 443

Open vipcxj opened this issue 4 years ago • 3 comments

IFrameAPITest failed because the wrong port. This pull request make test work on the host with a port other than 443, such as 8080.

vipcxj avatar May 27 '20 14:05 vipcxj

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

jitsi-jenkins avatar May 27 '20 14:05 jitsi-jenkins

FilmstripOnlyTest#testDisplaysDeviceSelection also failed, too. I dig into it and found APP_ID is undefined. and window.location.search and window.location.params are all empty. but a url with config hash(https://localhost:8080/XXX#interfaceConfig.filmStripOnly=true) works well, FilmstripOnlyTest#testLoadsOnlyTheFilmstrip success and the OnlyTheFilmstrip page shows.

vipcxj avatar May 27 '20 14:05 vipcxj

@damencho: Can you look this PR?

Neustradamus avatar Oct 28 '20 01:10 Neustradamus