jitsi-meet-ios-sdk-releases icon indicating copy to clipboard operation
jitsi-meet-ios-sdk-releases copied to clipboard

Created package 3.4.1

Open mudilajaganios opened this issue 4 years ago • 8 comments

mudilajaganios avatar Apr 24 '21 07:04 mudilajaganios

Why is this not merged?

peterz avatar Sep 09 '21 10:09 peterz

Why should it be?

saghul avatar Sep 09 '21 10:09 saghul

@saghul SPM is the modern for Swift, it is really helpful if it can support SPM

duong-xendit avatar Sep 20 '22 02:09 duong-xendit

It's on our roadmap to support it, but we need to publish WebRTC as SPM first. This is a good start though!

saghul avatar Sep 20 '22 07:09 saghul

@saghul What is the status of the SPM support ? It seems that you published the WebRTC as SPM already.

valentinwallet avatar Apr 05 '24 09:04 valentinwallet

YEs, we did, I completely forgot about this issue though 😅

What would be missing here?

saghul avatar Apr 05 '24 15:04 saghul

It seems that the main obstacle to integrating the JitsiMeetSDK with SPM has been overcome by enabling WebRTC with SPM, which has been successfully implemented. Now, the focus is on ensuring compatibility of the JitsiMeetSDK with SPM.

I've also seen an other pull request related to this issue : https://github.com/jitsi/jitsi-meet-ios-sdk-releases/pull/9. Though they may be dated, they can serve as a starting point.

Thank a lot for your message, SPM compatibility would greatly benefit us, offering an alternative to Cocoapods 😊

valentinwallet avatar Apr 05 '24 15:04 valentinwallet

Oh, I had missed #9 too 🤦

Looks like that one is closer to what's needed, so I'll try to take a look at it soon!

saghul avatar Apr 05 '24 17:04 saghul

Hey @saghul any news on this? Let me know if I can help you 😃

valentinwallet avatar Apr 25 '24 07:04 valentinwallet

Looks like we are close. I am not very familiar with the syntax. These dependencies need to be put there too: https://github.com/jitsi/jitsi-meet-ios-sdk-releases/blob/6541d094c60b4d58246199cf6cfea7272cecda8e/JitsiMeetSDK.podspec#L13

saghul avatar Apr 25 '24 07:04 saghul

Yes, if you look at the other pull request as an example, you can see how it's done :

.package(url: "https://github.com/Giphy/giphy-ios-sdk", from: "2.2.4")

valentinwallet avatar Apr 25 '24 08:04 valentinwallet

At this point it would be helpful to have a new PR with all changes applied. We just released SDK 9.2.2 so it will take a few weeks until we do the next. It should be attainable to merge before the next one. Are you up for that?

saghul avatar Apr 25 '24 08:04 saghul

Yes I can try that !

valentinwallet avatar Apr 25 '24 08:04 valentinwallet

Hey @saghul you can have a look at it here : https://github.com/jitsi/jitsi-meet-ios-sdk-releases/pull/11 😃

valentinwallet avatar Apr 25 '24 16:04 valentinwallet

Continues in https://github.com/jitsi/jitsi-meet-ios-sdk-releases/pull/11

saghul avatar Apr 26 '24 15:04 saghul