jitsi-media-transform icon indicating copy to clipboard operation
jitsi-media-transform copied to clipboard

DON'T MERGE YET: removed TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA cipher

Open nils-ohlmeier opened this issue 2 years ago • 1 comments

This PR removes the last DTLS ciphers which still use SHA1.

I manually verified with Wireshark that TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 successfully gets negotiated with Chrome, Firefox and Jigasi.

Note: don't merge yet as this depends on Jigasi updates in production first.

nils-ohlmeier avatar May 31 '22 19:05 nils-ohlmeier

Codecov Report

Merging #419 (4c84f41) into master (095605d) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #419      +/-   ##
============================================
- Coverage     43.33%   43.31%   -0.02%     
  Complexity      560      560              
============================================
  Files           145      145              
  Lines          5767     5765       -2     
  Branches        797      797              
============================================
- Hits           2499     2497       -2     
  Misses         2960     2960              
  Partials        308      308              
Impacted Files Coverage Δ
...rc/main/kotlin/org/jitsi/nlj/dtls/TlsClientImpl.kt 67.21% <100.00%> (-0.53%) :arrow_down:
...rc/main/kotlin/org/jitsi/nlj/dtls/TlsServerImpl.kt 55.00% <100.00%> (-0.56%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 095605d...4c84f41. Read the comment docs.

codecov[bot] avatar May 31 '22 19:05 codecov[bot]