jitsi-media-transform icon indicating copy to clipboard operation
jitsi-media-transform copied to clipboard

Save old TCC feedback timestamps, in case of packet reordering.

Open JonathanLennox opened this issue 5 years ago • 2 comments

Based on libwebrtc's equivalent code (as used in Chrome) -- see https://webrtc.googlesource.com/src/+/refs/heads/master/modules/remote_bitrate_estimator/remote_estimator_proxy.cc .

JonathanLennox avatar Feb 12 '20 17:02 JonathanLennox

Here's the performance of TccGeneratorNode.observe() before and after my patch: Screen Shot 2020-02-18 at 4 50 01 PM Screen Shot 2020-02-18 at 4 50 15 PM

So it is a noticable relative increase, but not that large an absolute increase as a percentage of the total bridge time.

JonathanLennox avatar Feb 18 '20 22:02 JonathanLennox

Since most of this PR ended up in https://github.com/jitsi/jitsi-media-transform/pull/222, I've rebased this one to have just the remaining part.

JonathanLennox avatar Feb 24 '20 18:02 JonathanLennox