jigasi icon indicating copy to clipboard operation
jigasi copied to clipboard

fix: re-establish connection with transcription service if session is prematurely ended

Open AubynKen opened this issue 2 years ago • 1 comments

This PR fixes the issue mentioned in the thread below: https://community.jitsi.org/t/jigasi-randomly-starts-sending-raw-vosk-json-response-as-subtitles/117831

The problem came from lost websocket connection between jigasi and the VOSK transcription service. Before the change, a participant whose audio should be transcribed switches to the single request mode when the session is prematurely ended. The PR allows Jigasi to check whether streaming is supported by the transcription service, and if it is the case, re-establish the streaming session.

AubynKen avatar Oct 05 '22 10:10 AubynKen

I have signed the CLA. This PR is part of a project by France Université Numérique to improve the accessibility of the French government's video conference platform.

AubynKen avatar Oct 05 '22 10:10 AubynKen

Hello @damencho,

I'm bumping this PR as it has been stale for a while. Is there anything we can do to improve this PR?

Thanks :)

charles-zablit avatar Oct 25 '22 14:10 charles-zablit

Hey @rpurdel does this makes sense with your changes, I know you were also fighting with the single request thingy?

damencho avatar Aug 17 '23 13:08 damencho

@damencho This totally makes sense, in my opinion at least. And it also doesn't impact my implementation. The only thing I'm wondering is if we should still keep the sendSingleRequest method altogether? I mean if the streaming fails for any of the transcription services, why should sending single requests to the same service work?

rpurdel avatar Aug 17 '23 13:08 rpurdel

@rpurdel I agree, if we merge this basically the single request code will never be reached. I will go and merge this and we can do a follow up PR to drop that, after merging the whisper impl.

damencho avatar Aug 17 '23 13:08 damencho

I mean if the streaming fails for any of the transcription services, why should sending single requests to the same service work?

That was our reasoning when we were building this with @AubynKen 👍 I believe this was meant for the Google Cloud transcription service implementation.

charles-zablit avatar Aug 17 '23 13:08 charles-zablit

Thanks @charles-zablit @AubynKen

damencho avatar Aug 17 '23 13:08 damencho