jicofo icon indicating copy to clipboard operation
jicofo copied to clipboard

Update slf4j to 1.7.32

Open Neustradamus opened this issue 4 years ago • 3 comments

http://www.slf4j.org/news.html

Neustradamus avatar Apr 12 '20 09:04 Neustradamus

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

jitsi-jenkins avatar Apr 12 '20 09:04 jitsi-jenkins

Hey thanks for all the updates. Can you remind me if you've signed the CLA (feel free to email me).

bgrozev avatar Apr 12 '20 18:04 bgrozev

@bgrozev, @saghul: One PR here.

Neustradamus avatar Dec 31 '21 16:12 Neustradamus

@bgrozev: Why it has been closed?

Neustradamus avatar Dec 08 '22 03:12 Neustradamus

Because it no longer applies AFAIS since the dep has been updated.

saghul avatar Dec 08 '22 08:12 saghul

@saghul: My PR has been created "April 12, 2020".

I see now that a PR, a long time after has been done with this change, it is not SERIOUS!

  • https://github.com/jitsi/jicofo/pull/832

Neustradamus avatar Dec 08 '22 22:12 Neustradamus

And now there are: 2022-02-08 - Release of SLF4J 1.7.36 & 2022-11-25 - Release of SLF4J 2.0.5:

  • https://www.slf4j.org/news.html

Neustradamus avatar Dec 08 '22 22:12 Neustradamus

@saghul: My PR has been created "April 12, 2020".

I see now that a PR, a long time after has been done with this change, it is not SERIOUS!

April 12, 2020 is also the day I asked you about your CLA, which you never followed up on. Do you have any actual contributions to make, or are you just going to continue wasting people's time with PRs that may or may not compile and just bump random dependency versions without a clear reason? Do you actually use this project, or are you here just to comment?

bgrozev avatar Dec 08 '22 23:12 bgrozev

I will also add that this PR was open mid 2020, and in case you forgot, we were not idling around at that time, it was kinda busy, to put it mildly.

saghul avatar Dec 09 '22 09:12 saghul