jibri icon indicating copy to clipboard operation
jibri copied to clipboard

Hook on all participants left

Open zWaR opened this issue 4 years ago • 5 comments

Hi @bbaldino,

Thank you so much for the hook implementation https://github.com/jitsi/jibri/pull/315/commits That's really useful!

In https://github.com/jitsi/jibri/issues/325 we already talked about some of the hook related features and there is another one we just identified. Namely, we'd benefit from having a hook which is triggered when all participants leave the conference. We are wondering if a feature like that is already on your roadmap (or maybe even implemented and we missed it) and what you think of it. We are also willing to contribute, but before we do that, we want to check if you're perhaps already working on that and if this would be something you'd consider worthy adding to Jibri.

Thanks so much for the outstanding work on Jibri. W're having a lot of success of using it and are very satisfied with the results. Thanks also for the great responsiveness of you guys and the community!

zWaR avatar Oct 12 '20 21:10 zWaR

You're talking about a webhook when Jibri detects the conference is empty?

bbaldino avatar Oct 12 '20 21:10 bbaldino

Yes, exactly.

zWaR avatar Oct 12 '20 21:10 zWaR

Jibri treats the empty call like a "successful" finish, do you need to specifically know that the Jibri session ended due to an empty call? Or merely that it ended successfully?

bbaldino avatar Oct 12 '20 21:10 bbaldino

We'd need to know that it ended due to an empty call specifically.

zWaR avatar Oct 13 '20 00:10 zWaR

Gotcha. No plans for something like this. We'd need to surface the specific reason we transition to the finish state here at the Selenium level, but there would also need to be changes to continue to bubble that reason all the way up to the point where we could actually fire a webhook event with it.

bbaldino avatar Oct 13 '20 16:10 bbaldino