ice4j icon indicating copy to clipboard operation
ice4j copied to clipboard

Published 20 hours ago • verified publisher icon jitsi

Learn peer reflexive candidates from all STUN reqs

Open leedm777 opened this issue 9 years ago • 6 comments

This patch allows ice4j to learn peer reflexive candidates from all STUN requests, even if it will respond with a 487 Role Conflict. This allows peer reflexive candidates to be learned sooner, instead of waiting for conflict resolution to finish before learning the candidate.

This is necessary for interop with buggy peers that do not switch roles when they receives the Role Conflict error. Chrome 46.0.2490.86 (current version) appears to have this problem, which this patch alleviates.

I've looked at the relevant section of the spec (RFC 5244 section 7.2.1), and it appears that this behavior is not prohibited.

leedm777 avatar Dec 03 '15 00:12 leedm777

bump.

leedm777 avatar Jan 06 '16 02:01 leedm777

@bgrozev Can I get some feedback on this patch? Does it look legit? Is it likely to be merged?

leedm777 avatar Feb 04 '16 18:02 leedm777

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

jitsi-jenkins avatar Mar 23 '16 18:03 jitsi-jenkins

@jitsi-jenkins There should already be one on file for me.

leedm777 avatar Mar 23 '16 18:03 leedm777

@bgrozev I'm curious to the status on this one as well (bump); Seems like a short and simple patch that may help us out on our project with the latest merges from you this week.

mondain avatar Nov 26 '16 15:11 mondain

Sorry for the lack of response on this. It will take me some time to go over the patch, because of the potential implications. I will try and do it this week.

bgrozev avatar Nov 28 '16 15:11 bgrozev