ice4j icon indicating copy to clipboard operation
ice4j copied to clipboard

Question: Is NOMINATE_BEST_RTT implemented?

Open Askaholic opened this issue 4 years ago • 2 comments

I am contributing to a project that uses ice4j for playing a peer to peer game online. Naturally, we would like each peer to select the candidate pair which gives them the lowest latency. I see that the code has a nomination strategy NOMINATE_BEST_RTT, but it is not referenced anywhere else in the project. Is it missing implementation?

I also see that there is a comment here: https://github.com/jitsi/ice4j/blob/686164ffc4633c86f2f23c9e542119ac3da42cae/src/main/java/org/ice4j/ice/DefaultNominator.java#L46

Referencing a strategy called NOMINATE_FIRST_HIGHEST_VALID, but this doesn't seem to exist either.

Askaholic avatar Jun 11 '20 22:06 Askaholic

No, it's not implemented. Contributions would be welcome

bgrozev avatar Jun 12 '20 15:06 bgrozev

Ok, thanks for the confirmation.

Askaholic avatar Jun 12 '20 16:06 Askaholic