Add tcptype to Candidate toString method

Open jalaziz opened this issue 8 years ago • 3 comments

Oct 19 '17 02:10 jalaziz

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

Oct 19 '17 02:10 jitsi-jenkins

I also noticed Candidate doesn't take tcpType into account for equals. I didn't want to assume it was safe to add tcpType to equals(), since it could result in breaking code. However, I believe it's the right thing to do.

Oct 19 '17 07:10 jalaziz

As it turns out, Chrome does not accept the tcptype attribute in the SDP string for SSLTCP. This results in some conflicts with Jitsi / ICE4J.

Oct 23 '17 02:10 jalaziz