Even with ENABLE_RECORDING=0 the hamburger menu shows the option to record a meeting

[cedricroijakkers]

Since stable-4857, in the environment configuration, when the variable ENABLE_RECORDING is set to 0 (because the recording infrastructure is not deployed and/or configured), if you log in to a meeting and click on the hamburger menu, the option to record the meeting is still there.

Clicking on the record link obviously fails.

The recording option should not be shown if the ENABLE_RECORDING variable is set to 0.

[cedricroijakkers]

Just had a look in the web container. The generated configuration is as follows:

    // Recording

    // Whether to enable file recording or not.
    // fileRecordingsEnabled: false,
    // Enable the dropbox integration.
    // dropbox: {
    //     appKey: '<APP_KEY>' // Specify your app key here.
    //     // A URL to redirect the user to, after authenticating
    //     // by default uses:
    //     // 'https://meet.jitsi/static/oauth.html'
    //     redirectURI:
    //          'https://meet.jitsi/subfolder/static/oauth.html'
    // },
    // When integrations like dropbox are enabled only that will be shown,
    // by enabling fileRecordingsServiceEnabled, we show both the integrations
    // and the generic recording service (its configuration and storage type
    // depends on jibri configuration)
    // fileRecordingsServiceEnabled: false,
    // Whether to show the possibility to share file recording with other people
    // (e.g. meeting participants), based on the actual implementation
    // on the backend.
    // fileRecordingsServiceSharingEnabled: false,

    // Whether to enable live streaming or not.
    // liveStreamingEnabled: false,

Which seems to match the shell script:

    if [[ $ENABLE_RECORDING -eq 1 || x$ENABLE_RECORDING == xtrue ]]; then
        sed -i \
            -e "/\/\/ Recording.*/a hiddenDomain: '$XMPP_RECORDER_DOMAIN'," \
            -e "s#// fileRecordingsEnabled:.*#fileRecordingsEnabled: true,#" \
            -e "s#// liveStreamingEnabled:.*#liveStreamingEnabled: true,#" \
        /config/config.js
    fi

So did the default behaviour change maybe? Are the variables fileRecordingsEnabled and liveStreamingEnabled now true by default, and do we need to change the scripting?

[AndreasUfert]

I second this: ENABLE_RECORDING should be respected.

Furthermore, ENABLE_LIVESTREAMING needs to be added to the env file.

[mhow2]

@AndreasUfert remark above is still valid in release 6433.