docker-jitsi-meet icon indicating copy to clipboard operation
docker-jitsi-meet copied to clipboard

Published 20 hours ago • verified publisher icon jitsi

Unify hidden domain usage for recording and transcription

Open zobadaniel opened this issue 1 year ago • 7 comments

More generic approach to proper transcriber inclusion into docker.

I made a new pull request, based on the info & feedback from here: https://github.com/jitsi/docker-jitsi-meet/pull/1663

The patch is bigger because I renamed XMPP_RECORDER_DOMAIN. The name would be confusing if it is not the sole purpose of that domain.

I'm still not 100% sure this is the right way to do it. Please let me know your comments.

Patch has been tested vs release 9220.

zobadaniel avatar Feb 07 '24 12:02 zobadaniel

Any progress here? Looking forward for this to be merged

miro-ku avatar Feb 20 '24 12:02 miro-ku

I would like to test this PR on my development environment, however as it is now this patch doesn't apply cleanly on the master branch due to recent commits (notably 360361e5ea40ba509cae94ca7c33aa9304410ed8).

loli10K avatar Mar 27 '24 09:03 loli10K

I will try to update the patch versus master in the near future. In the meantime, please check release 9220, it should apply cleanly against this one.

zobadaniel avatar Mar 27 '24 09:03 zobadaniel

I can confirm this is working nicely on top of stable-9220, i am using this with some small changes (unrelated to this PR, just to get Vosk transcription instead of the default Google Cloud service), thanks.

loli10K avatar Apr 25 '24 16:04 loli10K

The requested changes have been implemented by @M4GNV5 and the PR rebased. Please re-check and merge if accepted.

zobadaniel avatar Jul 29 '24 13:07 zobadaniel