docker-jitsi-meet
docker-jitsi-meet copied to clipboard
jitsi
Enable VOSK Transcription
this creates 2 (maybe) new ENV variables to allow for easier VOSK integration. Per default, it is assumed GCLOUD is always used and that makes it hard(er) to set up VOSK within docker-jitsi-meet
I still need to add the GCLOUD check and set for the ENV GOOGLE_APPLICATION_CREDENTIALS /config/key.json within the run script (jigasi/rootfs/etc/services.d/jigasi/run) but I am not sure how to best approach this. Maybe lets define an additional variable (ENABLE_GCLOUD_TRANSCRIPTION) and use that?
I added a new var ENABLE_GCLOUD_TRANSCRIPTION but I am not sure, if my code at jigasi/rootfs/etc/services.d/jigasi/run seting the GCLOUD ENV for the key.json is working as intended
I also am not sure, if it would be better/nicer if we can chain the check for the GCLOUD creds in the 10-config:
I wanted to AND together the following checks:
if [[ ($ENABLE_TRANSCRIPTIONS -eq 1 || $ENABLE_TRANSCRIPTIONS == "true") && ($ENABLE_VOSK -eq 0 || $ENABLE_VOSK == "false") && ($ENABLE_GCLOUD_TRANSCRIPTION -eq 1 || $ENABLE_GCLOUD_TRANSCRIPTION == "true") ]] but that isnt working as I imagined it. I assume I am misunderstanding some syntaxes here?
Is there anything left to do? I would be happy to help.
It would be very useful when this gets merged. Thanks
Is there anything left to do? I would be happy to help.
It would be very useful when this gets merged. Thanks
I updated the requested changes (e.g. the variablenaming ENABLE_VOSK_TRANSCRIPTION) but I need to test it out on my testsystem first, which I unfortunately didnt get around to yet. If I botched up something, I also break the GCLOUD transcription ability, which more users seem to use than VOSK :)
Also I am not sure about the logic, that checks if transcriptions are on (but not gcloud) which I will get around to next week hopefully
Hi, is there any update on this, and is there anything I can do to help?
@janonym1 is there an update on this ? Would love to help if necessary.
@debendraoli @charles-zablit @rouaidakacem and everyone else asking to help: could you test this PR and report if it works, and in case you have to make any changes, which ones? Because even with my proposed change, I can't get this to work.
Been patiently waiting for this, hoping to see this in a release soon! Would love to help/test if there's an update on this
Hi @saghul What needs to be done here? I would like to help. It looks like the changes you requested have not been reviewed by you. Or have I missed something?
How can I/we help to get this merged?
@saghul I understand that. But from what I can see, the changes you requested have been made but not reviewed. Can you review them and point out the remaining conflicts?
I don't have write access here, so all I could do was create a new branch/PR to address the conflicts there.
Please do that. I can't merge the PR as is, even if the feedback was addressed, because there are conflicts.
Sorry, I must have overlooked the activity here. I solved the conflicts but I think I have a bug somehwere in the logic. Let me look for my hardcoded values (since it worked for me before) and crosscheck with the effective values here
I have a simlar patch, so I'd rather 👍 this than to post my own. I am also willing to help in order to get this merged.
I forgot to add, that you have to have a working SIP setup (server+account) and config for VOSK to work. Should I just assume it is setup or make a check (e.g. if JIGASI_SIP_URI is set)?
I also do not seem to get around the GCLOUD restriction; it needs to have a jigasi/config/key.json with valid credentials even when GCLOUD is deactivated. I am not sure how to get around this, maybe mock the credentials?
I forgot to add, that you have to have a working SIP setup (server+account) and config for VOSK to work. Should I just assume it is setup or make a check (e.g. if JIGASI_SIP_URI is set)?
This is not a jigasi issue, this is configuration issue and should be fixed, maybe in this PR?
I think I fixed that already. If you set ENABLE_TRANSCRIPTIONS the sip config is skipped now.