docker-jitsi-meet icon indicating copy to clipboard operation
docker-jitsi-meet copied to clipboard

Published 20 hours ago • verified publisher icon jitsi

COLIBRI_REST_ENABLED env var naming

Open sapkra opened this issue 3 years ago • 4 comments
trafficstars

@saghul Why is this variable called COLIBRI if it also enables the healthcheck endpoint (see docs)?

https://github.com/jitsi/docker-jitsi-meet/blob/6cf017619ec7c4c4ec11ab78a5cfec679bf897f1/jvb/rootfs/defaults/jvb.conf#L39

sapkra avatar Dec 11 '21 09:12 sapkra

Good point I think we just picked a bad name.

We can change it if we keep backwards compatible for a few releases though.

saghul avatar Dec 11 '21 09:12 saghul

Or introduce another one for health checks and if one of them is true the rest API will be enabled. WDYT?

Edit: but then we would still have the version endpoint which won't be covered by the name.

sapkra avatar Dec 11 '21 09:12 sapkra

I'd go with a single one to enable all REST API. I'm assuming everyone will connect to the JVB via some kind of proxy, but since you have more experience with this setup, I'm listening :-)

saghul avatar Dec 11 '21 10:12 saghul

Because it's just one option and isn't granular anymore it makes sense to just have a single variable. I mean this variable change for REST APIs was breaking anyway.

sapkra avatar Dec 11 '21 10:12 sapkra