Jitse De Smet

Results 26 comments of Jitse De Smet

I suggest making the functions all classes (they already get transformed to become objects in `functions/index`. We can do the same by creating a class for all of them and...

@rubensworks would we want to keep extensionFunction support like we do now? Maybe we can do that using a functionActor that just calls that config callback?

Think about util functions and put them in a bus if they are only required in that bus

The extension functions should still work. maybe we can have a "special function" look at the context and just call to it.

We want all a function-actors to be on single bus.

Alright, big refactor again. I think the control flow is as good as final. Names should definitely get fixed up! (It's truly a mess.) The next thing is to fix...

I think these first 2 if statements are either redundant, or we have a bug: https://github.com/jitsedesmet/comunica/blob/chore/prepare-function-bussification/packages/expression-evaluator/lib/functions/RegularFunctions.ts#L329-L336. The statements are also included in the spec: https://w3c.github.io/rdf-star/cg-spec/2021-12-17.html#sparql-compare. The statements call the `

@rubensworks yes, but since a predicate is always a named node in comunica, we can not compare it using `

Okey, This PR has been standing still for so long and Is so big. I will use this message (by editing it) to refresh my memory and explain to myself...

Looks like the spec and integration tests work (both excluding a single test, that I have disabled because (I think) they have only been added at V3)