brethap
brethap copied to clipboard
jithware
modify audio to fade in and out
This might be a slightly opinionated change, so feel free to ignore this PR. But I just wanted to share the changes in case someone else is also interested. With my headphones all sounds (but especially tone3/4) make an unpleasant (popping?) sound at the start and end because the audio is abruptly cut off.
To fix this, I edited all files to add a 25ms fade-in to all and a 25ms fade-out to tone 3 and 4.
Before:
After:
This PR is stale because it has been open for 60 days with no activity.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR was closed because it has been inactive for 14 days since being marked as stale.
I know this pull request was closed for a while, but I think this is very good change. I don't hear the popping sound at the start of the sounds with my headphones, but cut off at the end of tone 3 & 4 is very noticeable and unpleasant as described by @Findus23 . You can also hear the subtle "pop" at the end of the new tones, but it's definitively change for the better in terms of comfort of use.
This can be added. There was a merge conflict after the change in #117. The fix will need to be modified to the new silence removed audio files.
Thanks for the reminder, I forgot about this. I have now applied the same changes to the new audio files and pushed it to the audio-fix branch. So I think if you reopen this PR it should show up correctly.
"Reopen and comment" is disabled stating "The audio-fix branch was force-pushed or recreated". Perhaps checkout new from master and add updated audio files and create a new pull request?
"Reopen pull request" is disabled stating "The audio-fix branch was force-pushed or recreated". Tried checking out pull request #115 directly git fetch origin pull/115/head:pull-115 && git checkout pull-115 and there are merge conflicts in the branch. Unfortunately a new pull request will need to be created or I can download the audio files from audio-fix and add them directly to master. If the later is done then @Findus23 won't get credit for change in release notes.