add 'credit_card' module

Open jiro4989 opened this issue 6 years ago • 6 comments

Dec 22 '19 14:12 jiro4989

Do we want to support random numbers for different card providers? ex Visa, Amex, etc?

Dec 01 '22 14:12 fishnibble

We will support only Visa at first. We will support others later if someone requested.

Dec 01 '22 14:12 jiro4989

Would it be a good idea to add a card provider enum? then we can get card numbers like so faker.credit_card(CardProvider.VISA) If so where should we save the enum type?

Dec 01 '22 14:12 fishnibble

Looks good.

Dec 01 '22 14:12 jiro4989

Would it be good to save the credit_card enum in the folder with the interface? Or do we make a type folder for all enums?

Dec 02 '22 02:12 fishnibble

Please this.

Would it be good to save the credit_card enum in the folder with the interface?

Dec 02 '22 14:12 jiro4989