params on php::fpm are not used

[kitchen]

the php::fpm::package class takes its param defaults directly from php::fpm::params class, and not php::fpm, so the params on php::fpm never get used. I imagine there are more like this, as well.

I'll fix this, but I need an approach. right now you have php::fpm inheriting php::fpm::params and php::fpm::package inheriting nothing. Proposal: php::fpm::package (and config and daemon and such) inherit from php::fpm, which inherits from php::fpm::params. Defaults in the various php::fpm::* classes will come from php::fpm's parameters, and maybe even deprecate the parameters directly on them in favor of top level params on php::fpm

Then I should be able to fairly readily port this module to fedora 20 :)

[jippi]

Hi

I've only ever configured the plugin using hiera, so the inheritance may be a bit off :)

If you got the logic for that down, by all means PR a fix - it will be highly appreciated

Also fedora support would be amazing!

[parhamr]

+1 I’ve also seen this bug

[jippi]

Alright, if you got a PR that can resolve it, it would be highly appreciated