Juan Ignacio Polanco
Juan Ignacio Polanco
You're right, there's no reason to include the `examples/Manifest.toml` file, especially since the examples are executed with a different set of package versions when tests are run (see `runtests.jl`). For...
> Is there a reason to have a Project.toml for the test/ folder and the examples/ folder? Yes. Tests and examples use certain extra packages that we do not want...
Yes, my point of view was that, when user code is already type unstable, then we don't need to care too much about performance and thus making a copy is...
Because of [this](https://github.com/JuliaVTK/VTKBase.jl/blob/1f48d195fdf5bf35254228cca4797452c7b94d3d/src/mesh_cells.jl#L15-L16): ```julia # By default, cells are attached to unstructured grids. grid_type(::Type{
Hi, I completely agree with your remark: writing `.pvtu` files should work just like `.pvd` ones. It would be great if you could make a PR to change this.
Without the stack trace, I'm guessing the error comes from this line: https://github.com/jipolanco/PencilArrays.jl/blob/ea2975f0fd1eec0d9d90dba8ac241ec97a71024b/src/Transpositions/Transpositions.jl#L209 in the PencilArrays.jl package. The easy solution would be to remove the `own = false`, which is...
Thanks for testing. So the `mightalias` assertion which failed serves to check that the two arrays point to the same data, which should be the case here since you're doing...
Thanks, it looks like the `dims` argument of `unsafe_wrap` *must* be a `Tuple` of integers for `ROCArray`s. Could you try replacing your first modification to `unsafe_as_array` with the following two...
Awesome! I think it would make sense to contribute the `dataids` definition to the AMDGPU.jl package, since otherwise we're committing type piracy which is not very cool. ~~I'll probably submit...
It's likely a compatibility issue between MPI.jl and AMDGPU.jl. It may be fixed by adding `0.9` [here](https://github.com/JuliaParallel/MPI.jl/blob/2f88c970270f74a467e4bf9352b438fe78343644/Project.toml#L23). Besides I think AMDGPU.jl needs a version bump to include your `dataids` implementation...