monologue icon indicating copy to clipboard operation
monologue copied to clipboard

modified migration files

Open omricohen opened this issue 7 years ago • 9 comments

I removed all the migration updates and moved them into 4 their respective create migrations. This will greatly simplify new installs.

omricohen avatar Mar 01 '17 13:03 omricohen

I fixed the build. Should be back in businesss soon

msevestre avatar Mar 02 '17 22:03 msevestre

@omricohen could you somehow update that PR to trigger the build again?Thanks

msevestre avatar Mar 02 '17 22:03 msevestre

@msevestre I did -- still failed

omricohen avatar Mar 07 '17 16:03 omricohen

yeah thanks. @jipiboily is going to look into that soon :)

On Tue, Mar 7, 2017 at 11:39 AM Omri Cohen [email protected] wrote:

@msevestre https://github.com/msevestre I did -- still failed

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jipiboily/monologue/pull/312#issuecomment-284777947, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_jVYImMP3CwUH1l0oEjsNtaOiytILrks5rjYg3gaJpZM4MPoMc .

msevestre avatar Mar 07 '17 17:03 msevestre

yeah, I want to make the build pass again shortly. :)

jipiboily avatar Mar 07 '17 22:03 jipiboily

@omricohen while working on making the build pass (#301) I had to resetup Monologue locally, and the migrations worked perfectly fine for me.

What is this PR trying to fix/change exactly? Not 100% clear to me.

Thanks!

jipiboily avatar Mar 08 '17 01:03 jipiboily

That's going to be more complicated than I thought. See #301 please. Happy to pay $100 if someone wants to get Monologue back on track.

jipiboily avatar Mar 08 '17 02:03 jipiboily

Actually, see https://github.com/jipiboily/monologue/issues/314 instead.

jipiboily avatar Mar 08 '17 02:03 jipiboily

@jipiboily This PR makes it so that you can rollback a monologue install. The current migrations do not allow for a rollback. Plus, not point in keeping so many migration 'change' files, makes it harder to maintain and understand what is going on.

omricohen avatar Mar 14 '17 09:03 omricohen

I am going to close this PR as it is polluting my Review list and is clearly outdated :)

msevestre avatar Jun 28 '23 20:06 msevestre