Sites are obsolete

[vogella]

Looks like you still creating a software site https://github.com/jinmingjian/eclipse.themes.darker/tree/master/eclipse.themes.darker.site

p2 does not require this since a few Eclipse releases.

[jinmingjian]

thanks for pointing out. The site plugin is contributed by John. I am still not familiar with the p2 personally, because(as you may know) the p2 is notorious in its first several releases. The site.xml is just one file and conform to KISS. But it is welcome to learn how the p2 do this better:)

[vogella]

At least if you use a p2 update site, the site.xml is not used anymore. So it is not KISS.

2013/5/15 Jin Mingjian [email protected]

thanks for pointing out. The site plugin is contributed by Johnhttps://github.com/jinmingjian/eclipse.themes.darker/pull/1. I am still not familiar with the p2 personally, because(as you may know) the p2 is notorious in its first several releases. The site.xml is just one file and conform to KISS. But it is welcome to learn how the p2 do this better:)

— Reply to this email directly or view it on GitHubhttps://github.com/jinmingjian/eclipse.themes.darker/issues/16#issuecomment-17917445 .

[pulse00]

@jinmingjian @vogella we'll integrate the feature in our p2 repo next week: http://p2-dev.pdt-extensions.org/. It'll be provided as a nightly build if you're ok with that.

[vogella]

@pulse00 cool stuff, can you drop me an email to discuss this? [email protected]

[jinmingjian]

@pulse00 very thanks for your contribution! it is cool to see "PDT Extension Group" existed for kinds of goods for the PHP community:) And co-cheers for that the GAE supports PHP now:)