elm-xml-parser icon indicating copy to clipboard operation
elm-xml-parser copied to clipboard

Don't escape processing instruction value in the `format` function.

Open mkwiatkowski opened this issue 8 years ago • 1 comments

With escaping enabled "format 10" test was failing with:

✗ format 10

    { processingInstructions = [{ name = "xml", value = "version="1.0"" }], docType = Nothing, root = Element "a" [] [] }
    ╷
    │ Expect.equal
    ╵
    { processingInstructions = [{ name = "xml", value = "version=\"1.0\"" }], docType = Nothing, root = Element "a" [] [] }

I made the simplest change that would pass all tests. Another approach would be to make ProcessingInstruction.value be a (String, Maybe String) tuple or perhaps a List Attribute, although that would be a breaking change.

mkwiatkowski avatar Nov 03 '17 10:11 mkwiatkowski

@jinjor Hi there, any chance of this being merged and released?

mkwiatkowski avatar Nov 27 '17 19:11 mkwiatkowski