select-after-closing-current icon indicating copy to clipboard operation
select-after-closing-current copied to clipboard

Fails when using Ctrl+Click to open links from newtab

Open ghost opened this issue 2 years ago • 3 comments

Some debugging has shown me that this is because openerTabId is undefined when using ctrl+click. This causes the tab to never be inserted in the recent tabs object, so this addon fails to operate as expected (behaviour is exactly as described in #23)

Right-click and select 'open in new tab' works perfectly. I guess this is a firefox bug?

ghost avatar Mar 07 '22 06:03 ghost

I've just noticed, I was testing this by opening links from about:newtab, and that's where it fails. Ctrl+click works as expected from other pages (and openerTabId is defined and valid). Middle click works either way.

I should mention that I'm on nightly FF.

ghost avatar Mar 08 '22 02:03 ghost

I guess this is a firefox bug?

~~Seems so, I cannot reproduce this any more. Closing the issue for now, yay. Thanks for a super handy addon.~~

ghost avatar Nov 20 '22 08:11 ghost

Apologies, this was appearing to be fixed due to my mouse bindings, it is in fact broken as described.

ghost avatar Jan 14 '23 07:01 ghost