multithreaded-download-manager icon indicating copy to clipboard operation
multithreaded-download-manager copied to clipboard

Dark icon

Open happysurf opened this issue 5 years ago • 15 comments

In the Firefox addons dark page, the MDM icon is hard to see, will be great make a medium gray or something like that.

Dark Icon

happysurf avatar Oct 12 '19 08:10 happysurf

There is no way to specify two icons for light/dark themes, and the black icon is choosen to follow the style of built-in extensions.

How did you apply the dark theme to this page? The built-in dark theme does not affect about:addons.

jingyu9575 avatar Oct 13 '19 10:10 jingyu9575

For apply the dark theme set browser.in-content.dark-mode to true (default in Firefox 70 beta). In any case the built-in icon color is not only black, but there are many option to select in the options. For that the icon color in the add-ons page could be different to toolbar customized color.

Icon

IMHO, the best choice is #666666 or #808080.

happysurf avatar Oct 14 '19 06:10 happysurf

With dark theme and this pref set to true, the about:addon page is still light on my Firefox Nightly latest. Are you using userContent.css? How does the built-in icons such as Flash Player and Default Theme show?

The color option only applies to the toolbar icon. The addon icon in about:addons is a static property and cannot be changed in the program.

jingyu9575 avatar Oct 15 '19 16:10 jingyu9575

With dark theme and this pref set to true, the about:addon page is still light on my Firefox Nightly latest.

I don't know why but is the same for other users.

Are you using userContent.css?

No.

How does the built-in icons such as Flash Player and Default Theme show?

Icons

The color option only applies to the toolbar icon. The addon icon in about:addons is a static property and cannot be changed in the program.

I know, in fact you must decide a dark gray color or leave black with a light border all around IMHO..

happysurf avatar Oct 16 '19 06:10 happysurf

I don't know why but is the same for other users.

Some tests show that this is related to the system's theme. If the system's theme is not dark, an additional pref ui.systemUsesDarkTheme=1 is required.

built-in icons

I've modified the icon to follow the same color as the built-in ones. Please update to v2.3 and see if there are any problems.

图片

jingyu9575 avatar Oct 18 '19 11:10 jingyu9575

Please set svg.context-properties.content.enabled to true. This is required to apply context colors to third-party icons.

jingyu9575 avatar Oct 18 '19 11:10 jingyu9575

In the last Firefox 70 build2 + MDM 2.3, the toolbar icon no more change the color in light or white thru the MDM interface options but remain black. In addition also the add-on page icon is black. Yes, I have the dark theme in Windows 10. http://ftp.mozilla.org/pub/firefox/candidates/70.0-candidates/

happysurf avatar Oct 18 '19 15:10 happysurf

the toolbar icon no more change the color

The code is accidentally broken in v2.3. Fixed in v2.3.1.

the add-on page icon is black

This one? Have you set the pref svg.context-properties.content.enabled?

图片

jingyu9575 avatar Oct 18 '19 16:10 jingyu9575

With 2.3.1 the toolbar icon problem is fixed, but unfortunately the add-on page icon is still black with svg.context-properties.content.enabled to true.

happysurf avatar Oct 18 '19 16:10 happysurf

Please right-click the icon and select "inspect element". What's the element code (<img ...>)?

图片

jingyu9575 avatar Oct 18 '19 16:10 jingyu9575

Code

happysurf avatar Oct 18 '19 16:10 happysurf

Your about:addons is using the icon from addons.mozilla.org, which is only black. The new icon packed in the extension is not being used. I'm not sure why Firefox is picking this online icon. I'll look into it.

jingyu9575 avatar Oct 18 '19 16:10 jingyu9575

This morning in my office PC, with same Firefox configuration, the MDM add-ons page icon is white. This afternoon I will try to reinstall the extension.

Icons4

happysurf avatar Oct 21 '19 06:10 happysurf

Yes this src="jar:file:///..." is the correct local icon packed in the extension. The src="https://addons.cdn.mozilla.net/..." is the black one on the website.

I'm still not sure what causes Firefox to use the local or web icons. Right now on my system, Firefox prefers the local icon if it exists, and only use the web icon if the extension does not have icon packed.

jingyu9575 avatar Oct 21 '19 07:10 jingyu9575

Unfortunately on my netbook also after removed and reinstall MDM, the icon is still taken from Mozilla web site. EDIT: Same problem on my home desktop PC.

happysurf avatar Oct 23 '19 16:10 happysurf