Jinghuayao

Results 34 comments of Jinghuayao

feat(explore): Show confirmation modal if user exits Explore without saving changes

> > I think it makes sense! @kasiazjc wdyt? > > Good point, I'm thinking - maybe for consistency we should follow chrome flow actually instead of adding this one....

feat: Adds drill to detail context menu for ECharts visualizations

/testenv up

feat: Adds drill to detail context menu for ECharts visualizations

/testenv up FEATURE_DASHBOARD_CROSS_FILTERS=true FEATURE_DRILL_TO_DETAIL=true

feat: Adds drill to detail context menu for ECharts visualizations

I found that in treemap, if i move my mouse to the white edge and it will show drill to details too, is that expected? https://user-images.githubusercontent.com/81597121/182424965-323f2549-47f6-4802-b09b-9af455c0f35d.mov

refactor: Rewrites ColorSchemeControl with Typescript

I have tested this pr locally, worked as expected

feat(rightmenu): Add Datasets to + Menu and Hide Databases when one has been connected

/testenv up

feat(rightmenu): Add Datasets to + Menu and Hide Databases when one has been connected

LGTM!

feat(rightmenu): Add Datasets to + Menu and Hide Databases when one has been connected

/testenv up

feat(rightmenu): Add Datasets to + Menu and Hide Databases when one has been connected

Test the alpha and gamma role in local env and verified alpha user can see create dataset in + menu when 1 non-example db is added.

[WIP] feat(dashboard): Add fallback support for right-clicking on unsupported viz plugins

/testenv up FEATURE_DRILL_TO_DETAIL=true