now
now copied to clipboard
feat: add autocomplete
Are we also planning to implement autocorrection of the search term as well?
Codecov Report
Merging #579 (65e0305) into main (ea7eab1) will increase coverage by
12.18%
. The diff coverage is64.16%
.
@@ Coverage Diff @@
## main #579 +/- ##
===========================================
+ Coverage 39.64% 51.82% +12.18%
===========================================
Files 39 78 +39
Lines 2563 4509 +1946
===========================================
+ Hits 1016 2337 +1321
- Misses 1547 2172 +625
Flag | Coverage Δ | |
---|---|---|
now | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
now/admin/benchmark_flow.py | 0.00% <0.00%> (ø) |
|
now/admin/deploy_text_to_video.py | 0.00% <0.00%> (ø) |
|
now/admin/flow_results.py | 0.00% <0.00%> (ø) |
|
now/admin/run_performance_test.py | 0.00% <0.00%> (ø) |
|
now/admin/search.py | 0.00% <0.00%> (ø) |
|
now/admin/update_api_keys.py | 0.00% <0.00%> (ø) |
|
now/admin/update_email.py | 0.00% <0.00%> (ø) |
|
now/cli/parser.py | 0.00% <0.00%> (ø) |
|
now/client/__init__.py | 0.00% <0.00%> (ø) |
|
now/data_loading/build_datasets.py | 0.00% <0.00%> (ø) |
|
... and 75 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
I have two suggestions
:
- From the api perspective limit the size of characters or words using a threshold. This will prevent issues due to crawling attacks or misuse of the api. It also doesn't make sense to provide suggestions for very long word or sentence.
- You can also use this resource to improve the integration or e2e testing for the api.
Are we also planning to implement autocorrection of the search term as well?
no because autocorrection will also affect words like lottiefiles
and other custom words, besides this auto completion executor uses count so even if some users spell things in the wrong way the majority should spell right thus our suggestions will be correct
@azayz Can we move the search
button to align with the search bar? You can use columns to keep them side-by-side. This way we can move the suggestion up to be close to the search bar.