jina icon indicating copy to clipboard operation
jina copied to clipboard

[WIP] feat: executor to gcp custom container

Open zac-li opened this issue 1 year ago • 2 comments

Goals

Similar to https://github.com/jina-ai/jina/pull/6046, we need to use jina to serve as a fastAPI for GCP.

Bunch of setup codes are copied, as Sagemaker and GCP requirements are mostly the same, except that GCP requires API request and response in certain format:

Request: https://cloud.google.com/vertex-ai/docs/predictions/custom-container-requirements#request_requirements Response: https://cloud.google.com/vertex-ai/docs/predictions/custom-container-requirements#response_requirements

TODO

  • [ ] Resolve the docarray validation issue
  • [ ] Finish the unittests

zac-li avatar Jan 15 '24 10:01 zac-li

Codecov Report

Attention: 108 lines in your changes are missing coverage. Please review.

Comparison is base (be263b1) 75.06% compared to head (b258808) 47.90%. Report is 1 commits behind head on master.

Files Patch % Lines
jina/serve/runtimes/worker/http_gcp_app.py 0.00% 93 Missing :warning:
jina/serve/runtimes/worker/request_handling.py 9.09% 10 Missing :warning:
jina/serve/runtimes/servers/http.py 70.00% 3 Missing :warning:
jina/serve/runtimes/asyncio.py 33.33% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6136       +/-   ##
===========================================
- Coverage   75.06%   47.90%   -27.17%     
===========================================
  Files         152      151        -1     
  Lines       14061    14133       +72     
===========================================
- Hits        10555     6770     -3785     
- Misses       3506     7363     +3857     
Flag Coverage Δ
jina 47.90% <10.74%> (-27.17%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 16 '24 03:01 codecov[bot]

hey @JoanFM , this is a WIP PR, so I will address your comments later. They are mostly copied from https://github.com/jina-ai/jina/pull/6046, so I will keep them consistent for now.

zac-li avatar Jan 17 '24 14:01 zac-li