jina icon indicating copy to clipboard operation
jina copied to clipboard

Published 20 hours ago • verified publisher icon jina-ai

Update uvicorn version

Open JoanFM opened this issue 1 year ago • 11 comments

Release of uvicorn 0.23.2 is making our tests hang because of the way how we handle websocket Gateway.

For now, we have fixed the uvicorn version, but it would be ideal to find the reason and unpin the version to profit from new benefits from it

JoanFM avatar Jul 31 '23 23:07 JoanFM

@jina-ai/product This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 14 days

jina-bot avatar Oct 30 '23 00:10 jina-bot

@MimicTester1307 please assign yourself here

JoanFM avatar Nov 23 '23 14:11 JoanFM

@MimicTester1307 please assign yourself here

@JoanFM I can't seem to assign myself, as I am not a collaborator. Please assign the issue to me.

MimicTester1307 avatar Nov 23 '23 17:11 MimicTester1307

I do not find how, but do not worry, u can start working on it

JoanFM avatar Nov 23 '23 17:11 JoanFM

Alright, thanks

MimicTester1307 avatar Nov 23 '23 17:11 MimicTester1307

Hi @JoanFM. In trying to reproduce the error, I found a couple of things and have some questions. Maybe it's due to my local setup, so I want to clarify:

  1. the build is tested against Python versions 3.7 & 3.8, right? Are there plans to upgrade to a later version?
  2. the current version of Jina depends on docarray <=0.21.0, but it seems that the build is configured to download the latest version of docarray. This caused some tests to fail. Please find attached a sample image below:

image

I will downgrade to the recommended version of docarray, but I just wanted to point this out.

MimicTester1307 avatar Dec 22 '23 02:12 MimicTester1307

for 1. We could chnage in the future, but is not related to this issur.

for 2. Jina is compatible with every docarray version, but we had so many tests with docarray 0.21.0 that we kept most of the tests unchanged and we install that version in our ci/cd

JoanFM avatar Dec 22 '23 07:12 JoanFM

Yes, the python version isn't related. I was just curious.

I see. Somehow it was the latest version of docarray that was installed in my environment. Maybe along the line the tests can be updated to use the latest version of docarray. In the meantime, I'll downgrade my version and just work on this issue. Thanks

MimicTester1307 avatar Dec 22 '23 12:12 MimicTester1307

it is a really big effort to change to the docarray version, and it would not add so much value.

JoanFM avatar Dec 22 '23 12:12 JoanFM

@jina-ai/product This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 14 days

jina-bot avatar Mar 22 '24 00:03 jina-bot

@jina-ai/product This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 14 days

jina-bot avatar Jun 21 '24 00:06 jina-bot