osmd-audio-player icon indicating copy to clipboard operation
osmd-audio-player copied to clipboard

Player dependent upon online connection?

Open matty90278 opened this issue 4 years ago • 2 comments

Hi, I'm using your player in my app, which loads all files and html/js locally. I notice that if the device is offline for a period of time, the audio player eventually stops working (the buttons don't respond even though OSMD rendering continues to work fine). I'm not sure if this is a WKWebkit issue or something to do with the player. But does the player rely on being online for its functionality? If so, is there a way to bypass that requirement and make it consistently work offline? Thanks!

matty90278 avatar Oct 27 '20 18:10 matty90278

@matty90278 There is a requirement for a network connection in order to load the soundfonts used for the actual playback. But when the instruments for the score is loaded loss of network connection should not affect functionality.

I've not done any dedicated offline-testing yet though.

The reasoning to not bundle all the instrument soundfonts is that doing so for all 128 MIDI instruments would bump the total package size way to much. In that case, an offline build with preloaded instruments would need to be offered separately.

jimutt avatar Nov 04 '20 19:11 jimutt

OK, thank you for the reply. Would you consider bundling just one midi instrument - piano - so there is always a default instrument available? That would be great for anyone wanting to use the player offline.

On Nov 4, 2020, at 11:20 AM, Jimmy Utterström [email protected] wrote:

@matty90278 https://github.com/matty90278 There is a requirement for a network connection in order to load the soundfonts used for the actual playback. But when the instruments for the score is loaded loss of network connection should not affect functionality.

I've not done any offline-testing though.

The reasoning to not bundle all the instrument soundfonts is that doing so for all 128 MIDI instruments would bump the total package size way to much. In that case, an offline build with preloaded instruments would need to be offered separately.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jimutt/osmd-audio-player/issues/43#issuecomment-721925088, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP2CA63BV7RD4MH4TBBFYWTSOGSP7ANCNFSM4TBGY7SQ.

matty90278 avatar Nov 04 '20 20:11 matty90278