osmd-audio-player icon indicating copy to clipboard operation
osmd-audio-player copied to clipboard

Published 20 hours ago • verified publisher icon jimutt

Repeat support

Open jimutt opened this issue 4 years ago • 5 comments

  • Handle barline repeats
  • Support toggling repeats on/off

Basic repeat handling would first need to be supported by the iterator/cursor in OSMD. Then it should be quite straight forward to just start using it here.

jimutt avatar Apr 29 '20 19:04 jimutt

Experimenting some with this in a private osmd fork: https://twitter.com/jimutt/status/1256223916751798276?s=20)

jimutt avatar May 01 '20 14:05 jimutt

Hi I'm so glad to see this repeat support function because I've been waiting for this for a very long time. I saw this work on Twitter but not updated on this project yet I want to try some of these repeat function If you don't mind, can I get some code about this repeat function?

best regards

djae88 avatar Jun 15 '20 19:06 djae88

Hi @jimutt , first of all, thanks for this excellent player that you've made... And, like @djae88 I'm looking forward to that feature. I'm working on a project right now that needs a feature like that. And now, we are thinking about fork your project to implement this by ourselves, but I wanna know if you have any plans to release this feature in the near future... Thanks again dude, for your great work, you've saved me a lot of work! :)

jonatasgrosman avatar Jul 11 '20 19:07 jonatasgrosman

@grosmanjs Thanks, I'm glad you like it! When it comes to repeat support the majority of work preferably needs to be done in the OSMD project, since the iterator belongs there. I did do some changes in my private OSMD branch (you can checkout my experimental changes here https://github.com/jimutt/opensheetmusicdisplay/pull/1) to support barline repeats pretty well, but I think it's quite far off from being mergeable to the main OSMD project. Especially if the text based repeats are to be generically supported.

Although lately I've been involved in some discussions with the OSMD main contributors about helping out with the official audio player functionally which they've got funding for.

So what I'm saying is that my primary focus now will most likely be to help work towards the official audio player. And as such I'm afraid you can't rely on me prioritizing the repeat functionality right now. So if you're in a hurry it could be an idea to look into it yourself 🙂

jimutt avatar Jul 12 '20 20:07 jimutt

Thanks for your reply @jimutt ... no problem, we'll find a way here to get around this issue by ourselves for now, but we are looking forward to this OSMD official player, please help those guys to release this asap 😄

jonatasgrosman avatar Jul 13 '20 15:07 jonatasgrosman