osmd-audio-player icon indicating copy to clipboard operation
osmd-audio-player copied to clipboard

instrument not detected coz method getSoundfontInstrumentName is wrong

Open burmistrov-alexander opened this issue 5 months ago • 0 comments

Hi!

this method doesnt replace round brackets

private getSoundfontInstrumentName(midiName: string): string { return midiName.toLowerCase().replace(/\s+/g, "_"); }

midiinstruments: ... [24, "Acoustic Guitar (nylon)"], [25, "Acoustic Guitar (steel)"], [26, "Electric Guitar (jazz)"], [27, "Electric Guitar (clean)"], [28, "Electric Guitar (muted)"], ... so, after calling getSoundfontInstrumentName() this names we got "acoustic_guitar_(nylon)" but it should be "acoustic_guitar_nylon", because file musyngkiteInstruments.ts include this name.

burmistrov-alexander avatar Sep 26 '24 13:09 burmistrov-alexander