jimtng

Results 174 comments of jimtng
trafficstars

@lolodomo / @kaikreuzer will this one not make it to 5.0? Sorry to ask, but the code freeze deadline is near. If so, I'll need to remove it from the...

+1 for including it into 4.2. The enhanced notification had already made it in between M3 and M4. If we didin't include this PR, we'd have a method in 4.1...

> or we need to do a breaking change in 4.3.0 Oh yes, indeed if this was postponed into 4.3.0 it would be a breaking change :(

PS, I'll update the jruby examples in the README _after_ this PR had been merged and the JRuby changes to support it also merged (which depends on this PR).

@miloit can you please fix the original post? There seem to be some missing information and incorrect formatting.

> At one point, I introduced formatting for durations in QuantityType (#4169). Would it make sense to also move this to this utility class? That way we may be able...

QuantityType also supports `1 month` which doesn't translate to 30 * 24 * 60 * 60 ``` irb(main):033> QuantityType.new("1 month").to_unit(Units::SECOND) => 2629746 s irb(main):037> 2629746.0 / 60 / 60 /...

> I don't think it harms to allow QuantityType syntax for parsing here. Anything allowing a user to use the same syntax in different places is a plus to me...