Jim Sheldon

Results 57 comments of Jim Sheldon

Hello @timothyclarke sorry again for the delay on this, I am working on this now. Can you help me understand the use case for this? The linked issue says: >...

Thanks for the background @timothyclarke We do have a simple test for the current functionality written in terratest, would you be comfortable writing an additional test for this new functionality?

We are interested in integrating this change, but it looks like it has conflicts now. Hopefully you are enjoying summer 😄, please respond when you can and we will collaborate...

Hello @SimonVHB thanks for the contribution! Please consider adding tests, let me know if you need help writing them.

Hello again @SimonVHB We've been putting more effort into adding support for other providers, do you still have a use case for this plugin with GitLab?

Glad to hear it! Some of the structures will be changing soon, which will require further changes to this PR. I will reach out once things have settled.

Just to make sure I understand, you have set `DRONE_JSONNET_ENABLED=true` for your drone server, which allows drone to read `.drone.jsonnet` files in your repo rather than `.drone.yml`? This doesn't directly...

I have discussed this with my team. We don't have any immediate plans to support this feature, but we would welcome a pull request to add it. For anyone else...

I looked into this today. Currently go-scm does not have `ListChanges` or `CompareChanges` implementations for Gitea https://github.com/drone/go-scm/blob/master/scm/driver/gitea/git.go#L76-L82 I am investigating, but so far it looks like the reason might be...

Hello @abdennour This change would be to just the plugin, if we end up working on a helm chart that would have to support this feature (if we implement it)....