image-resizer
image-resizer copied to clipboard
404s when using a default source
So, I'm running into a small issue, which has fairly simple workarounds, but wanted to see if you had any input on this.
Basically, I'm storing images in different folders, and sometimes, the folder names might start with an "s." This causes that portion of the URL to be identifier as the modifier (square, happens with others too, "w", "h", etc), removing the folder from the "resolved" URL. This happens only when you have a default source defined, since you don't need to specify the modifiers in the URL. So for example:
Image stored in /samples/test.jpg, using the local source. I can request it just fine via:
/elocal/samples/test.jpg
but if i just do:
/samples/test.jpg
then it tries to read the image from /test.jpg, resulting in a 404.
There are 2 simple workarounds - always specifying the source, or simply adding an underscore prefix to the base folders. Wondering if you had any ideas on how we might be able to avoid this situation in a more elegant way.
@ernestopye sorry for the delayed reply.
I dont see any reason why we should be able to validate the modifiers better and not throw a 404. For instance in your example /sample/...' is evaluating to
s: ample` as a modifier. We do know ahead of time what the sources are so we should be able to discount that one.
Let me work up a solution, but in the meantime your workarounds seem feasible.