shellwords icon indicating copy to clipboard operation
shellwords copied to clipboard

Windows compatibility

Open cowboyd opened this issue 5 years ago • 1 comments

👋 Hi there, we're using shellwords in@effection/node and it's been really great so far. I noticed that the last major change to this was eight years ago. Amazing how software can keep going and going!

https://github.com/thefrontside/effection/blob/v0/packages/node/src/exec.ts#L18

Anyhow, we're looking to add Windows support to this library and noticed that shellwords, when splitting a command on windows removes all \ characters which is the path separator on windows. So, for example:

\Users\cowboyd\Code\bigtest\node_modules\.bin\ts-node is converted to UserscowboydCodebigtestnode_modules.bints-node`

I'd be happy to submit a PR to fix this if you'd be willing to release it. Alternatively, we'd also be happy to take over maintenance of this repository and npm package if you'd be willing to donate it. Let me know and thanks again!

cowboyd avatar Nov 10 '20 16:11 cowboyd

Hi! Sure, I'd be happy to take a PR for this.

jimmycuadra avatar Nov 12 '20 20:11 jimmycuadra