configmap-reload icon indicating copy to clipboard operation
configmap-reload copied to clipboard

Published 20 hours ago • verified publisher icon jimmidyson

Make this more compatible

Open alexppg opened this issue 4 years ago • 5 comments

Hi I was trying to use this awesome project with plain docker (docker compose, actually) and I couldn't do it. Peeking the code I saw this conditional https://github.com/jimmidyson/configmap-reload/blob/master/configmap-reload.go#L166. Could we get rid of it? I understand that is done because k8s mount it's volumes with that notation, but It would be very useful to use this outside k8s.

alexppg avatar Mar 14 '20 22:03 alexppg

Ping.

alexppg avatar Jul 24 '20 09:07 alexppg

I've done it in this fork. https://github.com/little-angry-clouds/configmap-reload

alexppg avatar Sep 09 '20 20:09 alexppg

hey @alexppg! Feel free to submit a PR for review.

jimmidyson avatar Sep 17 '20 10:09 jimmidyson

+1 I have a shared volume that's being updated by a sidecar, so removing that configmap-only condition would be helpful.

william-tran avatar Dec 22 '21 15:12 william-tran

@william-tran In the meanwhile, you may want to use this. It's the images generated from my PR.

alexppg avatar Dec 28 '21 08:12 alexppg