configmap-reload icon indicating copy to clipboard operation
configmap-reload copied to clipboard

Support sending signals on file change

Open discordianfish opened this issue 6 years ago • 7 comments

Since Kubernetes 1.11 it's possible to share the IPC namespace, allowing to send signals between containers. Since many services reload their config on a signal, e.g SIGHUP, it would make sense to add this to the configmap-reloader.

Specifically I like to reload fluentd on configmap change.

discordianfish avatar Sep 17 '18 18:09 discordianfish

+1

gofman8 avatar Dec 24 '18 10:12 gofman8

Great idea. Any thoughts on what flags would look like and how to figure out what process to send signal to?

jimmidyson avatar Jun 24 '19 09:06 jimmidyson

to the question specifically I would probably expect something like:

./bin pgrep 'nginx'

Or something. Bonus points - allow re-implementing pgrep semantics -- --user et. al.

Note: This is a substantial amount of work; this may have poor ROI.

andrewhowdencom avatar Jul 02 '19 09:07 andrewhowdencom

should we copy this ? https://github.com/lvelvis/nginx-config-reload

zgfh avatar Oct 08 '20 06:10 zgfh

I wrote my own script that supports custom shell scripts and therefore also signals. It uses md5-based file comparison to detect changes on files: https://hub.docker.com/r/livingdocs/file-change-hook

It's not really a solution for this tool, but it might help some people.

marcbachmann avatar Oct 27 '20 12:10 marcbachmann

1

AkaiNoCat avatar Mar 22 '21 07:03 AkaiNoCat

Is there any change, that will be implement this year?

sinacek avatar Mar 17 '23 13:03 sinacek