configmap-reload icon indicating copy to clipboard operation
configmap-reload copied to clipboard

It works for secrets too!

Open alice-sawatzky opened this issue 6 years ago • 2 comments

I think it's worth mentioning in the documentation that it works for secrets too. Both to provide visibility to the feature and to lock it in as something users can rely on.

I assume it uses inotify or something similar, and not the kube API, in which case i would think also a sidecar container generating config files in a shared mount would also trigger it. If this is the case I think it would be useful to document the general versatility of this tool beyond its primary intended use-case of notifying on ConfigMap changes.

alice-sawatzky avatar Sep 12 '18 20:09 alice-sawatzky

Great point! This was originally written at a time when only configmaps were automatically rolled out to pods when they changed, not secrets.

jimmidyson avatar Jun 21 '19 10:06 jimmidyson

huh that's an interesting bit of history i was not aware of!

alice-sawatzky avatar Jul 03 '19 18:07 alice-sawatzky

Added this note to the README! Thanks for the reminder!

jimmidyson avatar May 16 '23 15:05 jimmidyson