oboe.js icon indicating copy to clipboard operation
oboe.js copied to clipboard

Bugfix/window is undefined for webworker

Open Aigeec opened this issue 5 years ago • 1 comments

Fixes #201

There were two issues with the 2.1.5 code.

The first as noted in the issue itself was that there were some references to window in Oboe itself. These have been removed.

The second was that with the package now bundled by webpack it also introduced a reference to window. This is a know webpack issue (https://github.com/webpack/webpack/issues/6642) (https://github.com/webpack/webpack/issues/6525). I've updated the webpack config to use an expanded definition of the globalObject as per (https://github.com/webpack/webpack/issues/6525#issuecomment-552140798)

Aigeec avatar Feb 09 '20 00:02 Aigeec

@Aigeec seems like a great thing to fix!

Unfortunately I'm not planning on working on Oboe moving forward. If you're confident with this PR, feel free to merge 👍

I've added you to the npm package as a maintainer so you can publish new versions in the future 😀

JuanCaicedo avatar Feb 12 '20 23:02 JuanCaicedo