jqScribble icon indicating copy to clipboard operation
jqScribble copied to clipboard

Width/Height options do not work as described in instructions

Open r-murphy opened this issue 11 years ago • 2 comments

In the readme file, it says that width and height use the parent values if these options are not set. Implying that the options should have higher priority. But the actual way it behaves is that the parent value has higher priority, and these values are only used if the parent container is too small.

Maybe should be something like this?

if(noparent)
{
    width = settings.width || $elm.parent().width();
    height = settings.height || $elm.parent().height();
}
else 
{
    $elm.append(canvas);
    width = settings.width || $elm.innerWidth();
    height = settings.height || $elm.innerHeight();
}

The width/height < 2 check becomes redundant if this logic is used. Not sure if this will break existing integrations, so it might need to be a new option. Or just reflect the actual behaviour in the instructions.

Thanks

r-murphy avatar Jan 30 '14 22:01 r-murphy

Thanks for the heads up. I'll check it out.

jimdoescode avatar Feb 03 '14 19:02 jimdoescode

Height can be set by changing the code in "jquery.jqscribble.js". Please find below the code:

if(noparent) { width = this.parent().width(); height = this.parent().height(); }

          //newly added
    if (options != undefined && options.height!=undefined){

       height = options.height;
    }

if(width < 2)width = settings.width; if(height < 2)height = settings.height;

Same way width can also be set.

tapash2407 avatar Apr 18 '14 07:04 tapash2407