jigold

Results 69 comments of jigold

I think if it's not too hard of a change, we should add the files with encoded secrets to something like `infra/gcp/data/...`. This makes it clear that these files have...

I'm so sorry. I didn't see you addressed my comments about the domain. I'll double check it one last time, but I'm sure it's fine.

It's probably not going to pass CI on the first try after the rebase. I'm mainly looking for feedback on the API first.

I think we should find a time to discuss this in person if the following explanation doesn't make sense. Right now, for small batches, we send one REST request to...

Ok. I made a new draft of the client, but didn't touch `_create_jobs` on the front end at all. Hopefully this is better because job ids are no longer negative....

What do you think of rather than negative numbers or written out types we just do this? `1a` and `1r`. `a` is absolute and `r` is relative. `1` implies absolute...

ok. that's fine. I was worried you wanted something like this, which I was going to strongly oppose: ``` parent_ids = [ {'id': 7, 'type': 'absolute'}, {'id': 8, 'type': 'in_update'}...

Great! I think we are good on the client. I'll modify it later today to use the new scheme. Before we get into the nitty gritty of the actual implementation,...

> A batch should not have a time_completed if it is still running Pretty sure I implemented this, but good to be in agreement before digging into the code. >...