ATACseqQC icon indicating copy to clipboard operation
ATACseqQC copied to clipboard

shiftGAlignmentsList time

Open josruirod opened this issue 6 years ago • 4 comments

Hi, congrats on the package. I'm going to integrate it in my pipelines I am particularly interested on shiftGAlignmentsList. I think it's really useful to shift reads while keeping bam format, even paired end. This is interesting for downstream analysis purposes. However, the importing bam file+shifting + exporting is taking a lot of time for averaged size bam files.

Just wanted to ask if there is any chance that this gets improved, maybe giving the option to use more threads? Don't know if it's possible.

Thank you,

josruirod avatar Jun 09 '18 10:06 josruirod

Hi,

Thank you for the comments. The memory and time cost is a big issue of ATACseqQC. Now I don’t have good solution for that. One Possible solution may split the bam file into several sub files and run it in multiple threads. Otherwise we need rewriting the code by c.

Best!

Your sincerely,

Jianhong Ou

On Jun 9, 2018, at 6:46 AM, josruirod [email protected] wrote:

Hi, congrats on the package. I'm going to integrate it in my pipelines I am particularly interested on shiftGAlignmentsList. I think it's really useful to shift reads while keeping bam format, even paired end. This is interesting for downstream analysis purposes. However, the importing bam file+shifting + exporting is taking a lot of time for averaged size bam files.

Just wanted to ask if there is any chance that this gets improved, maybe giving the option to use more threads? Don't know if it's possible.

Thank you,

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

jianhong avatar Jun 10 '18 21:06 jianhong

Sounds good, I hope this in your to do list.

Thank you for your insights

josruirod avatar Jun 11 '18 06:06 josruirod

Hi josruirod,

I improved the shiftGAlignmentsList function in the development version. Please have a try. Thank you.

jianhong avatar Oct 05 '18 15:10 jianhong

Thank you, appreciate the heads ups. I think the bigFile argument in readBamFile helps as well

josruirod avatar Dec 21 '18 11:12 josruirod