José Alamos
José Alamos
Ah sorry, you are right. What I meant is merging the counting mechanism, but not the usage on GNRC, as it's mainly used for IRQ offloading.
> @jia200x: This now largely reverts https://github.com/RIOT-OS/RIOT/pull/18465 and replaces the bhp_msg with bhp_event. this is definitely the way to go, thanks! Note that you could also just use `event` directly,...
code looks reasonable. Could you test these device drivers on more time before merging?
> Yes this fixes the issue. (Although for SLIP I would prefer https://github.com/RIOT-OS/RIOT/pull/18066) Should we then merge this one without the SLIP fix and get #18066 in?
Overall the code looks nice and the changes make sense. I left some comments there and plan to run some tests when they are addressed.
> That is not possible at the moment. I could however add e.g. a fall_back variable to the context struct and execute 1.0 code with 1.1 firmware if this flag...
Ideally members should be removed from the struct if they are not used. Although this rules out if(IS_USED), you can always write getters/setters that map to no op if you...
> @jia200x Do you need anything else to start testing? Time :smile: I will give it a look during the week
> I will give it a look during the week Uh, I couldn't make it this week :/. I will be back on Wednesday and plan to continue with testing
while testing, I realized the netif commands are not implemented in sc_gnrc_netif (so, you cannot e.g set the join key from the shell). This is important, since RIOTCtrl uses the...