filterrific icon indicating copy to clipboard operation
filterrific copied to clipboard

Helps to fix #79

Open apanzerj opened this issue 7 years ago • 7 comments

@jhund I thought that this might be helpful in resolving #79 in that you (as in the person using the gem, not you personally) can simply add to your code:

$('body').on('filterrific_filter:submit', null, null, function(e){
  history.pushState(null, '', "?" + $("#filterrific_filter").serialize());
});

Thoughts?

I don't want to add the above code itself directly to the gem since this also pollutes the URL and some people may not want that in their app.

apanzerj avatar Apr 28 '17 20:04 apanzerj

bump @jhund when you get a sec...

apanzerj avatar May 02 '17 18:05 apanzerj

@jhund you around?

apanzerj avatar May 09 '17 20:05 apanzerj

@jhund is this project dead?

apanzerj avatar May 11 '17 18:05 apanzerj

Is there any chance we can get this in? I‘d really like to update my url‘s via pushState and this seems to be the most elegant solution to hook into.

klaustopher avatar Feb 22 '18 21:02 klaustopher

ahahahahaha. probably never gonna happen. I'm fairly sure this project is very very dead.

apanzerj avatar Feb 22 '18 22:02 apanzerj

Adding my +1 to this. I don't think the project is dead, as @jhund is merging other PRs and crafting releases, it's just that managing open source projects is not a full time job, and he probably has other priorities. FWIW, I think this is a nice elegant solution, and I'd like to see this merged. Will use my own fork for now though.

pezholio avatar Feb 23 '18 09:02 pezholio

@pezholio the only things he's merged were by necessity. The license change was likely due to a corp entity poking him and the other change is a security patch. So, likely not "dead as in no pulse", but dead as in "the only maintainers aren't taking feedback requests".

Edit:

Just note, even if we don't care about why it was updated, two changes in close 10 months despite 7 pr's and 60+ issues smells dead to me.

apanzerj avatar Oct 15 '18 22:10 apanzerj