fselect icon indicating copy to clipboard operation
fselect copied to clipboard

I really like it, but can I trust its quality?

Open Byron opened this issue 7 years ago • 4 comments

First of all, I like what it can do and was about to install it when I noticed that there doesn't seem to be a single test.

Something that came to my mind is to test it entirely on CLI level to emulate how people would use it. Here is an example of journey level tests, which looks like this when run (it's all just bash).

Do you consider this this as much of a maintenance problem as I do? Please don't feel pressured or criticized, I really am interested to learn about the way this tool is/was developed.

Byron avatar Feb 25 '18 08:02 Byron

Hey Byron, why not just write the tests?, and send them as a pull request? it could a fun exercise, and you get to play around in Rust?

dataf3l avatar Feb 25 '18 09:02 dataf3l

Thanks, but I am already very busy exercising on share secrets safely :D!

Byron avatar Feb 25 '18 09:02 Byron

There should definitely be tests! First lexer and parser will be covered. Sample files to check basic scenarios go next. And finally we'll need few Vagrant VMs to test some more specific cases (not sure that all of VMs could be easily created/distributed).

jhspetersson avatar Feb 25 '18 13:02 jhspetersson

Sounds good, and good luck! If you think docker will also do, instead of using full-blown VMs, you could try the respective travis-ci feature.

Byron avatar Feb 25 '18 17:02 Byron