Jan Hrcek

Results 103 comments of Jan Hrcek

@fendor If I understand this correctly, the logic from this PR now lives in hls: https://github.com/haskell/haskell-language-server/blob/master/ghcide/session-loader/Development/IDE/Session/Implicit.hs So can this PR be closed then?

I can work on that if you give me some pointers, but in any case this PR looks like it's no longer relevant.

This is pretty annoying. I often find myself wanting to find (using haddock "search by pressing s" feature) which is currently not possible. I think it might be due to...

It would be great to have this merged. @vrom911 could you please check/merge this PR?

Ping @vrom911 Could you please check/merge this PR? Pretty please :slightly_smiling_face: :pray:

Great, I'm not in a hurry to implement it. Just a question about your proposed types: Wouldn't it make more sense to wrap the return types in Maybe? You know,...

Thanks, will look into it in the next few days.

What a journey! Can't wait to migrate our project to cabal and start using it. Thanks to everyone involved :clap:

I'm pretty this is duplicate of https://github.com/haskell/haskell-language-server/issues/4079 which I fixed in https://github.com/haskell/haskell-language-server/pull/4080 I just tested that it works in all the cases that you reported it was broken and it...

Just a heads up that I recently saw some version bump reverts recently, so it might not be good idea to always "blindly" accept changes to latest version. Example https://github.com/haskell/haskell-language-server/commit/01413e19e9cd515196dd329793f9bd2235c6d1e0...