docassemble icon indicating copy to clipboard operation
docassemble copied to clipboard

Make listening on HTTPS port configurable (for Podman rootless)

Open tonchikk opened this issue 1 year ago • 1 comments

Hi Team, https://github.com/jhpyle/docassemble/blob/5332f40cad442fed75a0a685ce996c30d4e78ecf/Docker/initialize.sh#L1378 Let's substitute 443 with ${HTTPSPORT:-443}

Same I've already done for unencrypted port:

$ vim env
$ cat env
PORT=9080
$ podman run --env-file=env -d -p 9080:9080 jhpyle/docassemble
3f563d9838b402d6a810af52694ca310f0314fe198616890a10f81e4af110941
$ podman ps
CONTAINER ID  IMAGE                                COMMAND               CREATED        STATUS        PORTS                   NAMES
3f563d9838b4  docker.io/jhpyle/docassemble:latest  /usr/bin/supervis...  7 seconds ago  Up 7 seconds  0.0.0.0:9080->9080/tcp  relaxed_darwin

tonchikk avatar Nov 26 '24 15:11 tonchikk

That line relates to the legacy Apache configuration, which isn't really used anymore. NGINX is the default web server now, and the NGINX configuration exists in other files.

I'm not sure why it matters what ports the container uses internally when you can remap the ports on the external side of the container. You can use -p 9080:80 and/or -p 9443:443 and podman will have no trouble binding to those ports in user mode.

jhpyle avatar Nov 29 '24 21:11 jhpyle